Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scroll position is not correct #3

Closed
blackbing opened this issue Apr 1, 2016 · 2 comments
Closed

scroll position is not correct #3

blackbing opened this issue Apr 1, 2016 · 2 comments

Comments

@blackbing
Copy link
Owner

based on #2 (comment) mentioned. ref video: https://youtu.be/xUU05hvL1Uc

在 home 頁面的時候，我滾動到頁面最底下，然後我點擊了導航欄的 about 鏈接，跳到新頁面後，頁面位置是錯誤的，頁面的位置應該是在頁面最頂上，這樣才是正確的。
@blackbing blackbing mentioned this issue Apr 1, 2016
Closed
@ChrisCinelli
Copy link

ChrisCinelli commented Oct 27, 2016 •
edited
Loading

This may be because you use lodash.throttle' instead of lodash.debounce:
https://css-tricks.com/debouncing-throttling-explained-examples/

With throttle if you have a burst of events, it may skip the actual final position.

blackbing added a commit that referenced this issue Oct 27, 2016
@blackbing
[#3] use debounce to replace throttle
d5427fd
@blackbing
Copy link
Owner Author

blackbing commented Oct 27, 2016 •
edited
Loading

@ChrisCinelli thanks for your advise and I've released [0.1.5]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blackbing @ChrisCinelli