-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stan warmup #16
Stan warmup #16
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 95.47% 96.78% +1.31%
==========================================
Files 10 15 +5
Lines 398 623 +225
==========================================
+ Hits 380 603 +223
- Misses 18 20 +2
Continue to review full report at Codecov.
|
ad14448
to
0779d3e
Compare
I need to separate "run" from the function that updates the stan warmup, in case we want to share information across chains. |
This is ready to review. We will just have to wait until #21 is merged to be able to test the Stan warmup with the NUTS kernel. |
8832413
to
a0afa52
Compare
The HMC proposal computes the transition probability based on the old proposal's weight instead of the new one, leading to an acceptance rate of 1. We fixed this.
In this Pull Request we implement the Stan warmup for a single chain. We also change the signature of the HMC and NUTS kernel factories. Example: