Support for ruby 3.2. Drop older ruby versions and que #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apuratepp
changed the title
martinBlacklane
approved these changes
Sep 29, 2023
pbauzyte
approved these changes
Sep 29, 2023
Comment on lines
-25
to
-31
| - gemfiles/que_0.12.2.gemfile | ||
| - gemfiles/que_0.12.3.gemfile | ||
| - gemfiles/rails_5.2.gemfile | ||
| - gemfiles/shoryuken_4.0.gemfile | ||
| - gemfiles/sidekiq_4.2.gemfile | ||
| - gemfiles/sinatra_1.4.gemfile | ||
| - gemfiles/sinatra_2.0.gemfile |
There was a problem hiding this comment.
Did all of those fail? If not, id say we leave the most reasonable ones still active!? That way we can ensure that some older versions are still running without major issues.
| @@ -19,22 +19,19 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| ruby: ['2.5.1', '2.7.2', '2.6.5'] | |||
| ruby: ['3.2.2'] | |||
There was a problem hiding this comment.
Why 3.2? At least ruby 3.0.x is still in security maintenance phase https://www.ruby-lang.org/en/downloads/ so id say its better to have the active ruby versions supported!?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Removed