Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portscanner Rework #1375

Merged
merged 9 commits into from
May 26, 2024
Merged

Portscanner Rework #1375

merged 9 commits into from
May 26, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented May 14, 2024

This PR simplifies the port scanner situation in BBOT by deleting nmap and replacing it with a brand-new masscan implementation, augmented to handle hostnames.

This accomplishes a few things:

  • helps relieve some of the confusion around there being two port scanners
  • better performance (masscan is much faster than nmap)

TODO:

  • Does masscan work with IPv6? (answer: YES)
    • localhost? Multiple interfaces? (answer: NO, but meh)
  • Handle IPv6 abort

@TheTechromancer TheTechromancer self-assigned this May 14, 2024
This was referenced May 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

Attention: Patch coverage is 81.18280% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 92%. Comparing base (a22cb9b) to head (b9c2e23).

Files Patch % Lines
bbot/modules/portscan.py 80% 32 Missing ⚠️
...step_2/module_tests/test_module_asset_inventory.py 86% 2 Missing ⚠️
bbot/modules/internal/speculate.py 0% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           bbot-2.0   #1375    +/-   ##
=========================================
+ Coverage        92%     92%    +1%     
=========================================
  Files           343     340     -3     
  Lines         23236   23048   -188     
=========================================
- Hits          21316   21156   -160     
+ Misses         1920    1892    -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit 1691332 into bbot-2.0 May 26, 2024
8 checks passed
@TheTechromancer TheTechromancer deleted the portscanner-rework branch June 25, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants