Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Timeouts #1379

Merged
merged 9 commits into from
May 16, 2024
Merged

Process Timeouts #1379

merged 9 commits into from
May 16, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented May 15, 2024

This PR adds the ability to specify a timeout when executing a subprocess. This is useful in cases like gowitness, which can stall out and never finish (see #1378).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92%. Comparing base (30f72d7) to head (63ddd6e).
Report is 9 commits behind head on dev.

Files Patch % Lines
bbot/modules/gowitness.py 72% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1379   +/-   ##
=====================================
+ Coverage     92%     92%   +1%     
=====================================
  Files        319     321    +2     
  Lines      20510   20591   +81     
=====================================
+ Hits       18850   18925   +75     
- Misses      1660    1666    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit 799124f into dev May 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants