remove parse_list_string #1495
Merged
remove parse_list_string #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbot/modules/ffuf_shortnames.py
Outdated
| @@ -3,7 +3,7 @@ | |||
| import string | |||
|
|
|||
| from bbot.modules.deadly.ffuf import ffuf | |||
| from bbot.core.helpers.misc import parse_list_string | |||
| from bbot.core.helpers.misc import chain_lists | |||
There was a problem hiding this comment.
there's no need to import here; you can call it directly with self.helpers.chain_lists()
bbot/core/helpers/misc.py
Outdated
| @@ -1202,10 +1209,15 @@ def chain_lists(l, try_files=False, msg=None, remove_blank=True): | |||
| try_files (bool, optional): Whether to try to open entries as files. Defaults to False. | |||
| msg (str, optional): An optional message to log when reading from a file. Defaults to None. | |||
| remove_blank (bool, optional): Whether to remove blank entries from the list. Defaults to True. | |||
| validate (bool, optional): Whether to perform validation for undesirable characters. Defaults to False. | |||
| validate (str, optional): When performing validation, what additional set of characters to block (blocks non-printable ascii automatically). Defaults to '<>:"/\\|?*)' | |||
There was a problem hiding this comment.
should be validate_chars
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1495 +/- ##
=====================================
+ Coverage 92% 92% +1%
=====================================
Files 327 327
Lines 21109 21105 -4
=====================================
+ Hits 19364 19368 +4
+ Misses 1745 1737 -8 ☔ View full report in Codecov by Sentry. |
TheTechromancer
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1485