Excavate - increase max redirects with max spider distance #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #965 +/- ##
=====================================
- Coverage 92% 92% -0%
=====================================
Files 305 305
Lines 18835 18845 +10
=====================================
+ Hits 17307 17314 +7
- Misses 1528 1531 +3 ☔ View full report in Codecov by Sentry. |
liquidsec
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small bug in excavate where when
web_spider_distancewas greater than 5, URLs would erroneously be tagged asspider-dangerbecause ofmax_redirects. If needed,max_redirectsis now upscaled to matchweb_spider_distance. A log message has also been added that explains why the event is tagged asspider-danger.