bypass IPs not in AllowedIPs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most proxy protocol implementions, such as MariaDB and Percona Server forces IP in AllowedIPs to use proxy protocol, and forces IP not in AllowdIPs to not use proxy protocol. They still accept IPs not in AllowdIPs to connect. They just won't parse proxy protocol header. I think that's a more user friendly way. I have read proxy protocol spec: > The receiver SHOULD ensure proper access filtering so that only > trusted proxyies are allowd to use this protocol. We meet the spec requirement because we do not allow untrusted proxyies to use proxy protocol. They are forced to use normal protocol.
|
@SteamedFish before I create this repo, I just integrated proxyprotocol into TiDB, and the first implements is act as your PR. But this design is not allowed by TiDB community, because community want to follow proxyprotocol's spec. So I think you should create a Issue at TiDB and discuss with community members. |
|
How about making |
|
@SteamedFish I see the comments in this feature's PR, and I think we can merge this PR. @coocood are you agreed? |
|
@blacktear23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most proxy protocol implementions, such as MariaDB and Percona Server
forces IP in AllowedIPs to use proxy protocol, and forces IP not in
AllowdIPs to not use proxy protocol. They still accept IPs not in
AllowdIPs to connect. They just won't parse proxy protocol header.
I think that's a more user friendly way.
I have read proxy protocol spec:
We meet the spec requirement because we do not allow untrusted proxyies
to use proxy protocol. They are forced to use normal protocol.