Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the audio changes #137

Closed
blake-mealey opened this issue Mar 10, 2022 · 0 comments · Fixed by #139
Closed

Support the audio changes #137

blake-mealey opened this issue Mar 10, 2022 · 0 comments · Fixed by #139
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@blake-mealey
Copy link
Owner

blake-mealey commented Mar 10, 2022

Context: https://devforum.roblox.com/t/action-needed-upcoming-changes-to-asset-privacy-for-audio/1701697

Audio will no longer cost Robux to upload but will have monthly limits on the number of assets that can be uploaded.

Our current implementation already supports this (any pre-quota audio assets will be uploaded but after the quota is reached, Roblox will reject requests with an error).

However, to better support this for our users, we should request the user's quotas and log a warning to tell the user how many they have left for the current period and when their quota will be reset. We can also fail early without attempting to upload if the user has already reached their quota.

Our docs also need updating since audio is always free now (just not always allowed).

I think this may also accelerate the need for #63 and #135.

@blake-mealey blake-mealey added the enhancement New feature or request label Mar 10, 2022
@blake-mealey blake-mealey added this to the v1.0.0 milestone Mar 10, 2022
@blake-mealey blake-mealey added the missing configuration Missing support for Roblox configuration label Mar 10, 2022
@blake-mealey blake-mealey added bug Something isn't working and removed missing configuration Missing support for Roblox configuration labels Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant