Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide function to init with both key and params #8

Open
tv42 opened this issue Aug 16, 2014 · 1 comment
Open

Please provide function to init with both key and params #8

tv42 opened this issue Aug 16, 2014 · 1 comment

Comments

@tv42
Copy link

tv42 commented Aug 16, 2014

I don't see how to use salt, personalization etc in combination with keyed hashing, without copy-pasting the memset/memcpy logic inside blake2b_init_key. Am I missing something that should have been obvious?

blake2b_init doesn't take a key.
blake2b_init_key forces params.
blake2b_init_param looks like a lower-level helper, and i don't see a clean, non copy-paste, way of getting the key update done after it.

I'm mostly interested in the SSE variant.

@tv42
Copy link
Author

tv42 commented Aug 16, 2014

The commit at https://github.com/tv42/blake2/commit/e5fb01792fc85b7820117b8f24a43c14d718ffa0 shows an example of what I'd like to see. It's needed for codahale/blake2#1 . Feedback is most welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant