Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please revise #67

Open
chile12 opened this issue Jul 14, 2017 · 3 comments
Open

Please revise #67

chile12 opened this issue Jul 14, 2017 · 3 comments

Comments

@chile12
Copy link

chile12 commented Jul 14, 2017

Forwarding the keyset here:
https://github.com/blazegraph/database/blob/master/bigdata-core/bigdata-rdf/src/java/com/bigdata/bop/rdf/join/ChunkedMaterializationOp.java#L396

does not go over well with adding something to it here:
https://github.com/blazegraph/database/blob/master/bigdata-core/bigdata-rdf/src/java/com/bigdata/rdf/lexicon/LexiconRelation.java#L2743

Which will result in an UnsupportedOperationException, as it does in my case.

@thompsonbry
Copy link
Contributor

thompsonbry commented Jul 14, 2017 via email

@chile12
Copy link
Author

chile12 commented Jul 16, 2017

1:
openjdk version "1.8.0_131"
OpenJDK Runtime Environment (build 1.8.0_131-8u131-b11-0ubuntu1.16.10.2-b11)
OpenJDK 64-Bit Server VM (build 25.131-b11, mixed mode)

2: no, but adding all members of unrequestedSidTerms and ivs (the forwarded Set) in a new Set instead of adding all of unrequestedSidTerms into ivs, solved that issue for me.
Changing the keyset can trigger all manner of side effects. Since you are removing the added keys later in the same method, consider changing this:
https://github.com/blazegraph/database/blob/master/bigdata-core/bigdata-rdf/src/java/com/bigdata/rdf/lexicon/LexiconRelation.java#L2899

@beebs-systap
Copy link
Contributor

See also BLZG-9000.

gserdyuk pushed a commit to gserdyuk/database-astr that referenced this issue Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@thompsonbry @chile12 @beebs-systap and others