-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bin/bldr update removes all composer dependencies - composer.json not found? #149
Comments
Those two arent supposed to be used for running your own composer install. Those are for installing third party |
But right now they uninstall existing project dependencies without asking. Are you sure, this is what you want? |
Its not actually bldr code: https://github.com/bldr-io/bldr/blob/master/src/Application.php#L118 Its embedded composer |
Maybe you want to rename the arguments to |
I can't change that command. It's not my command to change. And i have to disagree. A developer should know what executable they are executing. |
I understand, but it worries me a bit. Bldr seems like a hack to me now. Bldr is not just a random executable, but a configurable task runner. Nothing you want to be surprised of. Think of Murphy’s Law. |
@aequasi You can change the command names. The argument you pass to the constructor on those commands sets the prefix for the command name, which you're setting as empty ( Maybe |
While all build profiles work without using "run", update still doesn't work as expected:
Might be due to
in |
…ed for block install, update and autoload dump for issue bldr-io#149
Bldr comes with predefined
install
andupdate
commands that can not be overwritten in.bldr.yml.dist
. Those commands executecomposer install
/composer update
, but don't seem to findcomposer.json
:Basically, Bldr removes itself, which doesn't seem to be the intended behaviour. It probably looks for
composer.json
inbin
instead of the main directory?My
composer.json
looks like this (only the important parts):The text was updated successfully, but these errors were encountered: