feat: pool status and integration tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mootz12
approved these changes
Nov 22, 2022
| /// Pool status is changed to 'pool_status" if invoker is the admin | ||
| /// 0 - active, 1 - on ice, 2 - frozen | ||
| /// | ||
| /// Returns true on success and error otherwise |
There was a problem hiding this comment.
No need for this to return true, it can just return or be a pool error
| }; | ||
|
|
||
| // #[test] | ||
| // fn test_pool_borrow_no_collateral_panics() { |
There was a problem hiding this comment.
assuming this was an accident?
| use crate::common::{create_mock_oracle, create_wasm_lending_pool, PoolError}; | ||
|
|
||
| #[test] | ||
| fn test_set_status_not_admin_panic() { |
There was a problem hiding this comment.
positive tests for setting to active, on ice, and frozen should exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.