Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels aren't currently working as expected on GKE #4

Closed
JeanMertz opened this issue May 27, 2018 · 1 comment
Closed

Labels aren't currently working as expected on GKE #4

JeanMertz opened this issue May 27, 2018 · 1 comment

Comments

@JeanMertz
Copy link
Contributor

Even though this library has support for defining log labels, this isn't actually properly parsed by Stackdriver at the moment. See this PR for more details.

If the outcome of that PR is that it won't be supported, I'll remove the code from this library, if it is, I'll change the key to the right one (probably logging.googleapis.com/labels).

Until then, I'll leave it as is.
@JeanMertz JeanMertz mentioned this issue Dec 28, 2018
Closed
@torbjornvatn
Copy link

It is now apparently GoogleCloudPlatform/fluent-plugin-google-cloud#152 (comment)

mhindery pushed a commit to mhindery/zapdriver that referenced this issue Sep 27, 2022
@asahasrabuddhe
Merge pull request blendle#4 from lytics/27107-labels-on-parent
491708b 
BUGFIX: Only add labels to child core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@torbjornvatn @JeanMertz