MB-60945 - Add scorch event for pre merge check #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonymic-smokey
changed the title
metonymic-smokey
requested review from
abhinavdangeti,
Thejas-bhat,
CascadingRadium,
Likith101 and
moshaad7
metonymic-smokey
force-pushed
the
merge
branch
from
3bda8d8
to
9c5ee60
Compare
metonymic-smokey
changed the title
metonymic-smokey
changed the title
abhinavdangeti
requested changes
Apr 16, 2024
|
@metonymic-smokey have you checked why the unit tests are failing? |
abhinavdangeti
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an event to check whether a merge can proceed based on criteria set by the caller(eg. cbft). If not, it's aborted and the merger loop continues its next iteration.
Also includes minor refactor to the function signature of the event callback registry to accommodate the new event type.