MB-62230 - Functions to optimize pre-filtered kNN. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonymic-smokey
commented
Sep 6, 2024
metonymic-smokey
force-pushed
the
pre-filter-optimize
branch
from
731e09b
to
80eeb5d
Compare
metonymic-smokey
requested review from
abhinavdangeti,
Thejas-bhat,
CascadingRadium,
Likith101 and
moshaad7
metonymic-smokey
force-pushed
the
pre-filter-optimize
branch
from
80eeb5d
to
fdf8871
Compare
metonymic-smokey
force-pushed
the
pre-filter-optimize
branch
from
fdf8871
to
1be5679
Compare
metonymic-smokey
force-pushed
the
pre-filter-optimize
branch
from
a28a5a6
to
c1f9c3e
Compare
abhinavdangeti
requested changes
Sep 13, 2024
metonymic-smokey
force-pushed
the
pre-filter-optimize
branch
from
d34e6d8
to
3574636
Compare
will add it in a separate PR if required.
metonymic-smokey
force-pushed
the
pre-filter-optimize
branch
from
ea87881
to
481520a
Compare
| return clusterVectorIDMap, nil | ||
| } | ||
|
|
||
| func (idx *faissIndex) ObtainClustersWithDistancesFromIVFIndex(x []float32, centroidIDs []int64) ( |
There was a problem hiding this comment.
@metonymic-smokey I've some questions around why we're passing in an array of centroids and getting back an array of centroids again here, but we can tackle these separately.
abhinavdangeti
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functions for indexes to return -
Minor naming change -
IDSelectorBatch was a misnomer for a negatory selector - renamed it to IDSelectorNot.