Fixed 64-bit alignment panic in chunkedContentCoder on 32-bit platforms. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the fix in blevesearch#147, a 'panic: unaligned 64-bit atomic operation' is still occurring on some platforms. As noted in blevesearch#147, this commit implements the alternative fix by placing the bytesWritten field at the top of the struct. Per the Golang sync/atomic documentation, on ARM, 386 and 32-bit MIPS systems, this is the reliable way to prevent these issues. Signed-off-by: Callum Jones <cj@icj.me>
abhinavdangeti
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Thanks for the contribution @cj123 . Looks good to me. Let's wait on one other review.
abhinavdangeti
requested review from
metonymic-smokey,
moshaad7 and
Thejas-bhat
Thejas-bhat
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the fix in #147, a 'panic: unaligned 64-bit atomic operation' is still occurring on some platforms.
As noted in #147, this commit implements the alternative fix by placing the bytesWritten field at the top of the struct. Per the Golang sync/atomic documentation, on ARM, 386 and 32-bit MIPS systems, this is the reliable way to prevent these issues.