Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: filenamePrefix with folder is not working #12

Closed
TimPietrusky opened this issue Nov 20, 2023 · 1 comment
Closed

[BUG]: filenamePrefix with folder is not working #12

TimPietrusky opened this issue Nov 20, 2023 · 1 comment
Assignees
Labels
bug Something isn't working released

Comments

@TimPietrusky
Copy link
Member

Describe the bug

When sending a workflow to the worker that has a folder as part of the filenamePrefix, then the worker will not find the generated image and it will result in an error.

Repro MVP (Minimal Viable Procedure)

  • Create a workflow in Comfy
  • In the "Save Image"-node, use a folder int he filenamePrefix, like my/folder/output

Expected behavior

The image will be exported regardless of the filenamePrefix

@TimPietrusky TimPietrusky added the bug Something isn't working label Nov 20, 2023
@TimPietrusky TimPietrusky self-assigned this Nov 20, 2023
github-actions bot pushed a commit that referenced this issue May 28, 2024
## [2.1.3](2.1.2...2.1.3) (2024-05-28)

### Bug Fixes

* images in subfolders are not working, fixes [#12](#12) ([37480c2](37480c2))
Copy link

🎉 This issue has been resolved in version 2.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to alka7ex/runpod-worker-comfy that referenced this issue Sep 7, 2024
# 1.0.0 (2024-09-07)

### Bug Fixes

* check_server default values for delay and check-interval ([4945a9d](4945a9d))
* don’t persist credentials ([1546420](1546420))
* don't run ntpdate as this is not working in GitHub Actions ([2f7bd3f](2f7bd3f))
* got rid of syntax error ([c04de4d](c04de4d))
* images in subfolders are not working, fixes [blib-la#12](https://github.com/alka7ex/runpod-worker-comfy/issues/12) ([37480c2](37480c2))
* path should be "loras" and not "lora" ([8e579f6](8e579f6))
* removed xl_more_art-full_v1 because civitai requires login now ([2e8e638](2e8e638))
* return the output of "process_output_image" and access jobId correctly ([blib-la#11](https://github.com/alka7ex/runpod-worker-comfy/issues/11)) ([dc655ea](dc655ea))
* **semantic-release:** added .releaserc ([blib-la#21](https://github.com/alka7ex/runpod-worker-comfy/issues/21)) ([12b763d](12b763d))
* updated path to "comfyui" ([37f66d0](37f66d0))
* use custom GITHUB_TOKEN to bypass branch protection ([9b6468a](9b6468a))

### Features

* add ComfyUI-IDM-VTON custom node ([180e6fb](180e6fb))
* add ComfyUI-IDM-VTON custom node ([9c9d6c5](9c9d6c5))
* added default ComfyUI workflow ([fa6c385](fa6c385))
* added FLUX.1 schnell & dev ([9170191](9170191))
* added runpod as local dependency ([9deae9f](9deae9f))
* added unit tests for everthing, refactored the code to make it better testable, added test images ([a7492ec](a7492ec))
* added xl_more_art-full_v1, improved comments ([9aea8ab](9aea8ab))
* base64 image output ([blib-la#8](https://github.com/alka7ex/runpod-worker-comfy/issues/8)) ([76bf0b1](76bf0b1))
* change the runner ([1707e16](1707e16))
* example on how to configure the .env ([4ed5296](4ed5296))
* image-input, renamed "prompt" to "workflow", added "REFRESH_WORKER" ([blib-la#14](https://github.com/alka7ex/runpod-worker-comfy/issues/14)) ([5f5e390](5f5e390))
* logs should be written to stdout so that we can see them inside the worker ([fc731ff](fc731ff))
* network-volume; execution time config; skip default images; access ComfyUI via web ([blib-la#35](https://github.com/alka7ex/runpod-worker-comfy/issues/35)) ([070cde5](070cde5)), closes [blib-la#16](https://github.com/alka7ex/runpod-worker-comfy/issues/16)
* run the worker locally ([blib-la#19](https://github.com/alka7ex/runpod-worker-comfy/issues/19)) ([34eb32b](34eb32b))
* simplified input ([35c2341](35c2341))
* simplified input to just have "prompt", removed unused code ([0c3ccda](0c3ccda))
* support sd3 ([blib-la#46](https://github.com/alka7ex/runpod-worker-comfy/issues/46)) ([dde69d6](dde69d6))
* updated path to "comfyui", added "ntpdate" to have the time of the container in sync with AWS ([2fda578](2fda578))
* use local ".env" to load env variables, mount "comfyui/output" to localhost so that people can see the generated images ([aa645a2](aa645a2))
* use models from huggingface, not from local folder ([b1af369](b1af369))
* wait until server is ready, wait until image generation is done, upload to s3 ([ecfec13](ecfec13))

### BREAKING CHANGES

* we have 3 different images now instead of just one: base, sdxl and sd3

* ci: use branch name for creating dev releases

* ci: replace "/" with "-" to have a valid tag name

* ci: correctly handle the tag  name

* ci: build an image that contains sd3 using docker bake

* ci: use "set" instead of "args"

* ci: use "env" instead of "set"

* ci: use variables instead of args

* ci: set variables directly for the targets

* ci: write the secrets into the GITHUB_ENV

* ci: handle env variables correctly

* ci: use env variables from GitHub Variables

* ci: added back to env

* ci: print out env

* ci: adding the vars directly into the workflow

* ci: example workflow for sd3

* ci: renamed DOCKERHUB_REPO to DOCKERHUB_REPOSITORY

* ci: removed quotes for DOCKERHUB_REPOSITORY

* ci: only use DOCKERHUB_REPO in bake

* ci: added vars into sd3 target

* ci: added direct target

* ci: back to basics

* ci: multi-stage build to not expose the HUGGINGFACE_ACCESS_TOKEN

* ci: write everything into GITHUB_ENV again

* ci: use correct name for final stage

* ci: use correct runner

* fix: make sure to use the latest versions of all packages

* ci: simplified variables for all targets

* docs: added 3 images, updated build your own image

* docs: updated TOC

* ci: updated name

* ci: use docker bake to publish 3 images instead of just 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

1 participant