feat: package file validation #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaffney
force-pushed
the
feat/package-validate
branch
from
44a1ff4
to
9009a6a
Compare
wolf31o2
approved these changes
Mar 20, 2024
verbotenj
reviewed
Mar 20, 2024
| ), | ||
| ) | ||
| if err := pm.ValidatePackages(); err != nil { | ||
| slog.Error("problems were found") |
There was a problem hiding this comment.
Do we want to bring up problems?
There was a problem hiding this comment.
The problems found will be displayed as they are encountered in the validation process, but they display as warnings. This just gives an explicit failure at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135