-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider support for ed25519 keys #60
Comments
Unfortunately it isn't that easy. We are using libssh2 under the hood, and they do not have support for ecdsa keys yet. I think they might add it at some point or I will just get someone to do it ;) |
libssh2/libssh2#39 yeah buddy lightweight |
With the following
There's a workaround in adding
This is computationally expensive to undertake, it'd be great to have Blink be able to connect to systems using ECC if possible. Not sure when it'll land in libssh2, your linked issue is interesting. |
I'd contribute $$ for ed25519 support. |
I'm currently working on #59 (Persistent Connections) and was planning to jump on this right after completed. We can prioritise it by hiring someone to start working on it. I wanna reach out to a few developers that I have seen from the libssh2 repo, but if you know someone who might be able to do it, just let me know :) |
Hello, my company use ed25519 too and we will be really happy if Buddy can support it. Can't wait to be able to use this crypto with Buddy ;). |
An update on the state of things. I discussed with a lawyer and it seems that we are on solid ground if we are able to move to libssh: we are open source, and the additional restrictions clause wouldn't apply on this case. This would bring ed25519 a lot more useful features too, as they are usually more up to date. We are also exploring PuTTY as there is apparently another branch with support for ed25519, and also they are more up to date with new features. Any ideas, suggestions or just cheering appreciated :) |
Another ios app already support ed25519, it called Lterminal: Terrible UI/UX, however the only one at the moment supports ed25519. |
Great news, libssh2 now supports ed25519 and ECDSA! Time to revisit ;) |
Wonderful! \o/ |
Complete change of plans, but great news! I didn't want us to be behind again, and not using the fact that we are open source and can leverage a ton more libraries was weird. So we are moving to libssh! I've successfully compiled it and have it running for iOS. I'm migrating our ssh client, and key generation code. libssh has a few more advantages for us than libssh2:
The change is easy as our client isn't very complex, and the APIs for libssh are really well done. I will keep you posted! |
great news, this is the main reason I supported blink. Happy to beta test if needed! see my github profile for email. |
👍 Looking forward to this feature. :) |
Just picked up Blink for iOS. Would be willing to throw an additional $20 into the pot towards getting this feature added. Is there a recommended place to start a bug bounty for Blink, or should I do some research and decide on one myself? |
Hi!
It would be awesome if you would support using and generating ed25519 keys (in addition or even replacing rsa keys), since all major linux distributions, as well as macOS now support them.
See https://ed25519.cr.yp.to/ as well as http://security.stackexchange.com/questions/50878/ecdsa-vs-ecdh-vs-ed25519-vs-curve25519 for more info.
Ah, in order to generate one, just do: ssh-keygen -t ed25519
Thanks!
The text was updated successfully, but these errors were encountered: