Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic QR scan functionality #265

Closed
wants to merge 3 commits into from
Closed

Conversation

hryamzik
Copy link

@hryamzik hryamzik commented Apr 3, 2017

Added basic QR scan functionality. Works in the same way as clipboard pasting: only RSA keys are supported. Could help with #244 but also affected with it - invalid string leads to an infinite loop.

Didn't have a chance to test with pass-phrases.

QR code could be generated with

brew install qrencode
cat id_rsa|qrencode -t png -o rsa.png && open rsa.png

or if your screen is large enough

cat id_rsa|qrencode -t ANSI256

ANSI256 works fine for ed25519 on reasonably-sized screens but it's not supported yet.

@hryamzik
Copy link
Author

hryamzik commented Apr 4, 2017

@carloscabanero I could also fix infinite loop reported in #244 and add other key formats support, but starting this work from current master will make new PR conflict with this one.

@carloscabanero
Copy link
Member

Thanks a lot @hryamzik!!! Will definitely push to the next version. If you can add other key formats support, hit me up on cc (at) blink.sh and we can arrange something. We are currently evaluating to move to either PuTTy or libssh too, specially for other keys support and more features.

@hryamzik
Copy link
Author

hryamzik commented Apr 4, 2017

Is there anything preventing merge? Did I select wrong branch?

@hryamzik
Copy link
Author

hryamzik commented Apr 8, 2017

Looks like ed25519 isn't supported by libssh2 yet, that's bad news.

P.S.: OK, that's already discussed in #60.

@goerz
Copy link

goerz commented Jun 25, 2017

It would be great if Blink could display its private keys as a QR code as well. I do like to use just one key for Blink on all of my different iOS devices. This way, I could generate a key on the iPad, display it as a QR code, and then simply import it to the iPhone by pointing the camera to the iPad screen. That seems more secure than having to email the key to myself, or anything like that.

@hryamzik
Copy link
Author

I think private keys should be synced between devices with keychain, not QR codes.

Copy link

@loot-king loot-king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update files

@hryamzik
Copy link
Author

I don't have time to update this, feel free to push more changes here or to create a new PR.

@carloscabanero
Copy link
Member

We did not do a good job at merging this and it has I think there are better ways at moving keys around now. Closing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants