New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert session args is valid UTF-8 #1900

Closed

l2dy wants to merge 1 commit into blinksh:raw from l2dy:fix/assert-utf8

Contributor

l2dy commented Nov 18, 2023 •

edited

If it is NULL, null pointer dereferencing in makeargs() would result in undefined behavior. https://developer.apple.com/documentation/xcode/null-reference-creation-and-null-pointer-dereference


          Assert session args is valid UTF-8

a5a9c50

Contributor Author

l2dy commented Feb 17, 2024

UTF-8 was a red herring. It's makeargs() that should check if command is NULL before dereferencing *str.

l2dy closed this

l2dy deleted the fix/assert-utf8 branch

February 17, 2024 13:02

l2dy mentioned this pull request

Hard crash entering ctrl-^ then . then enter into blink> prompt #1994

Open

l2dy restored the fix/assert-utf8 branch

March 20, 2024 12:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment