Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Add Theme UI recipe (including MDX!) #1366

Merged
merged 35 commits into from
Dec 5, 2020
Merged

[legacy-framework] Add Theme UI recipe (including MDX!) #1366

merged 35 commits into from
Dec 5, 2020

Conversation

tundera
Copy link

@tundera tundera commented Oct 19, 2020

What are the changes and their implications?

This recipe adds Theme UI support to a blitz app. The implementation is based on the material-ui and chakra recipes. I've been using Theme UI pretty often this past year, mostly in Next.js projects. I've set this up a handful of times in Blitz, and it takes about a half hour each time to update/add the necessary files and packages. This recipe does the same configuration and setup for you automatically.

Progress 🏃

  • Add base theme file [2020-10-19]
  • Create injectInitializeColorMode method [2020-10-19]
  • Import InitializeColorMode component in _document [2020-10-19]
  • Create wrapComponentWithThemeProvider method [2020-10-19]
  • Import base theme and ThemeProvider in _app [2020-10-19]
  • MDX Layout components (see implementation)

Status

This is a work-in-progress with a couple outstanding issues. Working with jscodeshift methods for the first time, so any input is welcome!

Any other ideas or input is much appreciated 😀

Checklist

  • Tests added for changes
  • PR submitted to blitzjs.com for any user facing changes

@flybayer flybayer marked this pull request as draft October 25, 2020 19:59
@flybayer
Copy link
Member

Thanks @tundera! I marked this as draft for better tracking. Click "Ready for Review" when ready :)

@flybayer
Copy link
Member

Hey @tundera are you able to finish this?

.gitignore Outdated Show resolved Hide resolved
@tundera tundera marked this pull request as ready for review November 25, 2020 02:42
@tundera tundera closed this Nov 29, 2020
Copy link
Author

@tundera tundera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flybayer hey I think this is ready to go!

@flybayer
Copy link
Member

flybayer commented Dec 5, 2020

@tundera Awesome, good job!!

@all-contributors add @tundera for code

@allcontributors
Copy link

@flybayer

I've put up a pull request to add @tundera! 🎉

@flybayer
Copy link
Member

flybayer commented Dec 5, 2020

I changed the versions to be specific major version instead of latest to so a new major with breaking changes won't break this recipe.

@flybayer flybayer changed the title WIP: Add theme ui recipe Add Theme UI recipe (including MDX!) Dec 5, 2020
@flybayer flybayer merged commit 23b36b8 into blitz-js:canary Dec 5, 2020
@tundera
Copy link
Author

tundera commented Dec 6, 2020

Awesome!

@dillondotzip dillondotzip changed the title Add Theme UI recipe (including MDX!) [legacy-framework] Add Theme UI recipe (including MDX!) Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants