Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[legacy-framework] Fix and improve Theme UI recipe #1583

Merged
merged 39 commits into from
Dec 10, 2020
Merged

[legacy-framework] Fix and improve Theme UI recipe #1583

merged 39 commits into from
Dec 10, 2020

Conversation

tundera
Copy link

@tundera tundera commented Dec 7, 2020

What are the changes and their implications?

  • Add missing @theme-ui/prism dependency
  • Add transform function updateBlitzConfigProperty to enable MDX pages
  • Add a MDX page to demonstrate Theme UI MDX components spec

Checklist

  • Tests added for changes
  • PR submitted to blitzjs.com for any user facing changes

Philip Johnston added 30 commits October 18, 2020 14:15
forked repo
0da3a40
start theme-ui recipe based off current chakra one
d6c9343
initial setup added for theme-ui in blitz
d05ca2f
removing todo-list file
b996cf5
cleanup previous commit
c79b51f
Merge remote-tracking branch 'upstream/canary' into add-theme-ui-recipe
1aa14ef
setup basic mdx integration with theme-ui
51dbba2
cleanup merge changes
62b2bea
cleanup blocks.mdx
47a7ef7
fix theme-ui themeprovider not wrapping properly
13c6346
fix file add steps
206e628
add require functions
3fb7665
cleanup mdx page
c47ac85
remove deleted file
7a3490f
progress on updating blitz config module exports
39f13ad
fix prev commit recipe step
b4248fe
remove unused imports in recipe
2c6b595
more progress on wrapper for blitz config
eebd530
remove unnecessary linebreak in _document file
b4d3a2d
cleanup fns
011e4fa
work on initializer
a61aed2
more work on initializer
6f0e166
more work on initializer
72afb93
more work on initializer
24a8ccb
fixed initialize function on require
f042f66
remove page support for now
3b92150
Merge remote-tracking branch 'upstream/canary' into canary
59b3ae7
Merge branch 'canary' into add-theme-ui-recipe
a5f91bc
lockfile updates
b2f4037
Merge remote-tracking branch 'upstream/canary' into add-theme-ui-recipe
c2a2148
@tundera tundera changed the title Update theme UI recipe Update Theme UI recipe Dec 7, 2020
@flybayer
Copy link
Member

Cool thanks! Not sure about adding the mdx demo page, but let's roll with it for now :)

@flybayer flybayer changed the title Update Theme UI recipe Fix and improve Theme UI recipe Dec 10, 2020
@flybayer flybayer merged commit 78410ab into blitz-js:canary Dec 10, 2020
flybayer pushed a commit that referenced this pull request Dec 11, 2020
@tundera @flybayer
Fix and improve Theme UI recipe (#1583)
72d62b6 
Co-authored-by: Brandon Bayer <b@bayer.ws> (recipe)
@dillondotzip dillondotzip changed the title Fix and improve Theme UI recipe [legacy-framework] Fix and improve Theme UI recipe Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flybayer flybayer Awaiting requested review from flybayer

Assignees
No one assigned
Labels
status/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tundera @flybayer