Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[legacy-framework] Fix blitz compile bug with Typescript noPropertyAccessFromIndexSignature (patch) #2385

Merged
merged 2 commits into from May 25, 2021
Merged

[legacy-framework] Fix blitz compile bug with Typescript noPropertyAccessFromIndexSignature (patch) #2385

merged 2 commits into from May 25, 2021

Conversation

nimashoghi
Copy link

Closes: blitz-js/legacy-framework#259

What are the changes and their implications?

Bug Checklist

  • Integration test added (see test docs if needed)

Feature Checklist

@nimashoghi nimashoghi requested a review from flybayer as a code owner May 24, 2021 15:23
@blitzjs-bot blitzjs-bot added this to In Review in Dashboard May 24, 2021
@flybayer flybayer changed the title Fixed blitz compile bug with noPropertyAccessFromIndexSignature Fixed blitz compile bug with Typescript noPropertyAccessFromIndexSignature (patch) May 25, 2021
@flybayer flybayer added the 0 - <(^_^)> - merge it! ✌️ Kodiak automerge label May 25, 2021
@flybayer flybayer changed the title Fixed blitz compile bug with Typescript noPropertyAccessFromIndexSignature (patch) Fix blitz compile bug with Typescript noPropertyAccessFromIndexSignature (patch) May 25, 2021
@flybayer
Copy link
Member

Thank you!!

@kodiakhq kodiakhq bot merged commit 4a9776c into blitz-js:canary May 25, 2021
@blitzjs-bot
Copy link
Contributor

Added @nimashoghi contributions for code

@blitzjs-bot blitzjs-bot moved this from In Review to Done in Dashboard May 25, 2021
@dillondotzip dillondotzip changed the title Fix blitz compile bug with Typescript noPropertyAccessFromIndexSignature (patch) [legacy-framework] Fix blitz compile bug with Typescript noPropertyAccessFromIndexSignature (patch) Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flybayer flybayer flybayer approved these changes

Assignees
No one assigned
Labels
0 - <(^_^)> - merge it! ✌️ Kodiak automerge status/done
Projects
No open projects
Dashboard
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blitz build fails with noPropertyAccessFromIndexSignature
3 participants
@nimashoghi @flybayer @blitzjs-bot