[legacy-framework] Add ability to access req and res objects in blitz passport implementation
#2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @doncicuto!! Looks good. I'll wait a bit to merge until we are ready to release a breaking change |
flybayer
changed the title
req and res objects in blitz passport implementation
|
Added @doncicuto contributions for code |
|
Just what I wanted! |
|
@flybayer Do you know when this will go into stable release? I'm trying to use canary but is not working :/ |
|
Thanks! Awesome 💪 |
dillondotzip
changed the title
req and res objects in blitz passport implementationreq and res objects in blitz passport implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: blitz-js/legacy-framework#278
What are the changes and their implications?
Request and response objects are now available when using a callback for
passportAuthadapter. Using the request object we can have access to the query and its parameters to customize our passport strategies (e.g., invitation codes, referal codes).A test hasn't been provided as no previous test is available for passport-adapter. I'd try to think how to implement one in a different issue.
Bug Checklist
Feature Checklist