Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix duplicate image types (requires adding line to global.d.ts) #2597

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

sam3d
Copy link

@sam3d sam3d commented Jul 25, 2021

This PR attempts to fix the duplicate image types present in next/types/global that have since been stripped out and migrated to next/image-types/global. This, as a byproduct, uses the correct new svg typings in image-types that uses an any type instead of StaticImageData.

/// <reference types="next" />
/// <reference types="next/types/global" />
/// <reference types="next/image-types/global" />

Correct next/types/global: https://github.com/vercel/next.js/blob/canary/packages/next/types/global.d.ts

Correct next/image-types/global: https://github.com/vercel/next.js/blob/canary/packages/next/image-types/global.d.ts

@sam3d sam3d requested a review from flybayer as a code owner July 25, 2021 15:01
@sam3d sam3d changed the title Fix image types Fix duplicate image types Jul 25, 2021
@flybayer
Copy link
Member

Sweet, thank you @sam3d!!

@flybayer flybayer changed the title Fix duplicate image types Fix duplicate image types (requires adding line to global.d.ts) Jul 29, 2021
@flybayer flybayer merged commit aeb2a38 into blitz-js:canary Jul 29, 2021
@blitzjs-bot
Copy link
Contributor

Added @sam3d contributions for code

@sam3d sam3d deleted the fix-image-types branch July 29, 2021 15:27
@dillondotzip dillondotzip changed the title Fix duplicate image types (requires adding line to global.d.ts) [legacy-framework] Fix duplicate image types (requires adding line to global.d.ts) Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants