[legacy-framework] Fix broken cli when using npm where global blitz version used instead of local #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flybayer
commented
Jun 20, 2020
| @@ -14,7 +14,8 @@ console.log( | |||
|
|
|||
| let usageType: "local" | "monorepo" | "global" | "global-linked" | |||
|
|
|||
| const localCLIPkgPath = path.resolve(process.cwd(), "node_modules", "@blitzjs/cli") | |||
| const localCLIPkgPath1 = path.resolve(process.cwd(), "node_modules", "@blitzjs/cli") | |||
| const localCLIPkgPath2 = path.resolve(process.cwd(), "node_modules/blitz/node_modules/@blitzjs/cli") | |||
There was a problem hiding this comment.
Actual path of the local installed module can be one of these two paths.
dillondotzip
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes and their implications?
This fixes a bug where
blitz -vVwill returndebug: globalwhen run inside a blitz project. This means it's using the globally installed blitz package.This also was causing the following error when running
blitz generate:So I also added a try/catch around prettier in the generator to ensure that a prettier failure doesn't block file generation.
Checklist