This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
AudioBugfix for Samsung/Android Browser #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Samsung Devices (on my Galaxy S4Mini) playing a sound effect sometimes results in a crash, throwing the following Exception: InvalidStateError: DOM Exception 11 I've found out that it could happen that chan.waSource.stop( 0 ) throws this exception. However, as far as I understand the source, this happens if stop is called twice or when waSource Object isn't playing. So this if-branch shouldn't be reached, but it does. I've fixed it by catching the exception and ignoring it, which is fine in this case. I'm sure there must be a more cleaner solution, but I wasn't able to find one. This fix worked fine for me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Samsung Devices (on my Galaxy S4Mini) playing a sound effect
sometimes results in a crash, throwing the following Exception:
InvalidStateError: DOM Exception 11
I've found out that it could happen that chan.waSource.stop( 0 )
throws this exception. However, as far as I understand the source,
this happens if stop is called twice or when waSource Object
isn't playing. So this if-branch shouldn't be reached, but it does.
I've fixed it by catching the exception and ignoring it, which is
fine in this case.
I'm sure there must be a more cleaner solution, but I wasn't
able to find one. This fix worked fine for me.