Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update egui to v0.25 #157

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

tosti007
Copy link
Contributor

@tosti007 tosti007 commented Jan 9, 2024

This PR updates the egui dependency to the latest v0.25. I think I added the correct changes (atleast it runs fine), but a better review would be appreciated. Additionally did a drive-by change of changing a fixed version to a relative path.

Draft because the bevy_basic example isn't updated yet, we'll have to wait for mvlabat/bevy_egui#248 to be merged (and released) first.

Copy link
Contributor

@oisyn oisyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@jzanecook
Copy link

Working for me!

@tosti007 tosti007 marked this pull request as ready for review January 29, 2024 14:00
@tosti007
Copy link
Contributor Author

Since mvlabat/bevy_egui#248 is taking a bit longer than I anticipated, I think we could also do the version bump without bumping the example and do that in a separate PR once that's merged.

@blitzarx1
Copy link
Owner

blitzarx1 commented Jan 29, 2024

I agree. I ll merge this later today. And ship new release.

@blitzarx1 blitzarx1 merged commit fdadaa2 into blitzarx1:master Jan 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants