Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for compilation error as sprintf is now deprecated. #181

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bdcbqa314159
Copy link

There was an error during the compilation. The function sprintf has been replaced by snprintf accordingly.

blitz/array/fastiter.h Outdated Show resolved Hide resolved
@bdcbqa314159
Copy link
Author

Please find the code modifications as suggested.
Cheers.

@slayoo
Copy link
Member

slayoo commented Dec 30, 2022

Thanks! Sorry for delayed reply.
I've just noticed that BUFFER_SIZE is probably a common macro name, and it would be better to avoid any name cash with other libraries (see https://github.com/search?q=%22%23define+BUFFER_SIZE%22&type=code).

BTW, this PR also made me realize that we have still not recovered our continuous-integration facility for testing Blitz PRs after the shutdown of Travis... - we need to rewrite the .travis.yml file into .github/workflows/tests.yml one!

@bdcbqa314159
Copy link
Author

Hey! I took so long sorry for that but I am very up to contribute more here :)

@slayoo
Copy link
Member

slayoo commented Jul 12, 2024

Thank you @bdcbqa314159!
We now also have CI script for Github Actions, and it actually helped here - there seem to be some compilation errors, could you please have a look? Thanks!

@bdcbqa314159
Copy link
Author

Hey for some reason the auto formatting was causing these errors - I forced the c++11 in the cmakelists and things look a bit better. I would like to update the includes but one by one and piece by piece because there is a lot to do. Do you have a framework to test code and see things in your personal computer or you only rely here?

@bdcbqa314159
Copy link
Author

hello? :)

@slayoo
Copy link
Member

slayoo commented Jul 22, 2024

Do you have a framework to test code and see things in your personal computer or you only rely here?

The two test suite calls:

make check-testsuite # Build and check the testsuite
make check-examples # Build and check the examples

is what we have for testing - either locally on or CI.

There are a lot of changes in this PR not related with the title - IIUC, from some code autoformatter - could we perhaps separate it into another PR and make it enforced by CI (so that all new PRs would be checked if formatting matches)?

Finally, let me ask @citibeth, @papadop for your view on the requirement of C++11 here, and how should we communicate it in the README, etc?

Thanks!

@bdcbqa314159
Copy link
Author

ok sure - the thing was as soon I did the change for the macro all these errors came up but by addressing the cmakeLists everything went fine. Do let me know how to proceed after we hear from @citibeth and @papadop. Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants