-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for compilation error as sprintf is now deprecated. #181
base: main
Are you sure you want to change the base?
Conversation
Please find the code modifications as suggested. |
Thanks! Sorry for delayed reply. BTW, this PR also made me realize that we have still not recovered our continuous-integration facility for testing Blitz PRs after the shutdown of Travis... - we need to rewrite the |
Hey! I took so long sorry for that but I am very up to contribute more here :) |
Thank you @bdcbqa314159! |
Hey for some reason the auto formatting was causing these errors - I forced the c++11 in the cmakelists and things look a bit better. I would like to update the includes but one by one and piece by piece because there is a lot to do. Do you have a framework to test code and see things in your personal computer or you only rely here? |
hello? :) |
The two test suite calls: blitz/.github/workflows/main.yml Lines 34 to 35 in f24a250
is what we have for testing - either locally on or CI. There are a lot of changes in this PR not related with the title - IIUC, from some code autoformatter - could we perhaps separate it into another PR and make it enforced by CI (so that all new PRs would be checked if formatting matches)? Finally, let me ask @citibeth, @papadop for your view on the requirement of C++11 here, and how should we communicate it in the README, etc? Thanks! |
There was an error during the compilation. The function sprintf has been replaced by snprintf accordingly.