Increasing General Performance of MFHelper and al #232
Conversation
…mply change towns 1. Move the player act variable detector out of the while loop because we don't need it anymore in that main loop. We just need to query the act once to sync with the leader's starting town. 2. add a new goto command that will listen in a similar manner to the follower script.
Just like in Mephisto.js and Andariel.js, a function is used to broadcast the leader's intent on changing acts prior to doing so. This allows the MFHelper to rapidly react to the leader's intention to change acts rather than previous implementations which relied on the leader's current act.
36d71ff2543a74b5758b6eca69765e72.mp4 |
makes sense, no?
Ra-Ni
changed the title
|
minor change, unicast is safer.
|
getting an error when using these update files. |
woops forgot curly bracket
ill work on it tonight. they made changes to it |
There was a problem hiding this comment.
Thanks for making a pull request!
I been a bit behind on things, so sorry if you had to wait a while. I never use MFHelper so i have nothing to say about the content, but i have a few suggestions for small code changes, with examples how i should do it. Feel free to ignore my examples and find your own fixes =)
Seems good for the rest! Thanks
Broadcast only if MFLeader is true (reduces workload).
removed bin search in favor of just pop
TK packet casting is active if packetcasting is 2. Else, skill cast it.
Appreciate your feedback. I implemented the changes you suggested. |
|
still throws an error from mfhelper line 118 |
This does not make sense, but eh. Could anyone confirm this? =) |
I'm not seeing that issue. I just imported the changes and it's running as expected; having them switch acts early does seem to speed things up. @XoniBlue make sure you're using an up to date Misc.js, older version don't have the findPlayer function. |
|
After I pulled this commit my bot team stopped working. I can see my leader saying things like "goto A2" but followers are ignoring the command in most cases. In some other cases, leader doesn't say "goto AX" at all. I'm not sure what's going on. Anybody else seeing this behavior? |
My team hasn't had that issue. They follow the leader just fine up until Chaos where MFHelper gives up and DiabloHelper takes over. Two things I have noticed is that it's a bit slower to give up on MFHelper once they reach CS since the area check was removed (not really a big deal and expected) and that after Baal I have the leader run additional scripts (so no more followers at that point) and the leader will sometimes say to go to the wrong act. I haven't had time to look into that one though. |
Hmmm. Must be some (mis)configuration on my side. |
Previous implementation relied on the leader's current act and resulted in huge delays between changing towns. This motivated me to remove the redundant checks for the leader's act to only once - when the player first joins the game. The remaining act changes are performed by the leader telling the helper to switch acts (much like in follower).
The code has been tested on a stable release and I saw some differences between the stable and dev version. I'd appreciate it if you can confirm it works.