Manualplay fixes #361
Merged
Manualplay fixes #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quality set was overwritten, when uniqe and set of same class occured when set item dropped that had unique of same classid
settings being displayed
- ActionHooks changes: - Changed order of ActionHokks.event switch case to check the key toggles first - Changed blockKeyEventFlags array into blockKeyEvent function and removed the duplicate calls with the re-ordered case structure - Changed the getHook check for the settings menu to just use TextHooks.displaySettings rather than boolean casting a possible failed get - wrapped event in try - catch - finally as we are playing manual and a failed event shouldn't kill mapthread, we are present so just log the error for our info. Also finally ensures that action is always reset to null - GemHunter fixes - Removed Town.storeGem from Town.doChores. We shouldn't always carry gems it takes invo space - Changed canStashGem to return true if we aren't currently running the GemHunter script, again to make sure we don't fill our invo with gems - Changed storeGem to getGem for a clearer meaning, and only have it run if we are in the GemHunter script currently. Likely to change that behavior later as it makes sense that if we come across a gem shrine during travels to go get our best gem from the stash first - Fixed how pickit handles keeping gems, We now only keep them for GemHunter, and we only keep 1 of each type wanted. Also changed the result to be accurate rather than use cubing result
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two minor fixes for manual play