Add Slack alert option #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulshngill
reviewed
Jan 30, 2023
airflow/dags/utils/error_handling.py
Outdated
| f"task_id: {task_id}, log_url: {log_url}, context: {context}", | ||
| ) | ||
|
|
||
| platform = Variable.get(f"alert_platform", "discord") |
There was a problem hiding this comment.
Suggested change
| platform = Variable.get(f"alert_platform", "discord") | |
| platform = Variable.get("alert_platform", "discord") |
There was a problem hiding this comment.
Thanks! Fixed as per suggestion.
I think test fix is going to be a separate task. From the recently closed PRs, we are ignoring the failed test. @gulshngill
gulshngill
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLO-143
Default alert platform remains as Discord (backward compatible).
Slack is now added as an option.
The
alert_platformAirflow variable will allow developers to choose the platform to receive alerts, i.e.,discordorslack.Developers choosing
slackhave to further define the following variables:slack_alerts_webhook_urlslack_alerts_default_ownerslack_alerts_dag_owners[optional]Related PR: polygon-etl-config