Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mStable protocol #132

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

AyadiGithub
Copy link
Contributor

What?

Adding support for mStable protocol

How?

Used contract parser to build the table definitions

@AyadiGithub AyadiGithub changed the title Feature/mstable Add support for mStable protocol Feb 16, 2023
@TimNooren
Copy link
Collaborator

@AyadiGithub Please check the validateJsonTest results:)

@AyadiGithub
Copy link
Contributor Author

AyadiGithub commented Feb 17, 2023

@AyadiGithub Please check the validateJsonTest results:)
@TimNooren
oops! fixed them.
cliTests failure is due to the PR coming from a fork and GitHub actions not being able to access this repo's secrets. According to @charlielewisme

Copy link
Collaborator

@TimNooren TimNooren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I found at least two call definitions that have multiple signatures (SaveWrapper_call_saveViaUniswapETH and imUSDVault_call_stake). So please be aware that you might only see invocations of the defined signatures. I will check what our convention is wrt overloaded functions and table names.

@TimNooren TimNooren merged commit 88c1e69 into blockchain-etl:main Feb 21, 2023
@TimNooren
Copy link
Collaborator

@AyadiGithub Bit of a hold up, but these tables should now be available.

@AyadiGithub AyadiGithub deleted the feature/mstable branch March 1, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants