Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add correct click handlers to close button touch start event #206

Merged
merged 1 commit into from
May 24, 2019

Conversation

lnbc1QWFyb24
Copy link
Collaborator

Closes #205

@lnbc1QWFyb24 lnbc1QWFyb24 added the bug Something isn't working label May 23, 2019
@lnbc1QWFyb24 lnbc1QWFyb24 requested a review from cmeisl May 23, 2019 23:50
@lnbc1QWFyb24 lnbc1QWFyb24 self-assigned this May 23, 2019
@cmeisl cmeisl merged commit 6092eb8 into develop May 24, 2019
@cmeisl cmeisl deleted the fix/modal-on-close branch May 24, 2019 00:18
cmeisl added a commit that referenced this pull request May 24, 2019
* resize iframe after hiding modal (#198)

* update readme with mobile support info and web3 initialization example (#200)

* update readme with mobile support info and web3 initialization example

* add mobile section

* update to version 0.8.1

* change pageY and pageX to screenY and screenX (#204)

* add correct click handlers to close button touch start event (#206)
@cmeisl cmeisl mentioned this pull request May 24, 2019
cmeisl added a commit that referenced this pull request May 24, 2019
* resize iframe after hiding modal (#198)

* update readme with mobile support info and web3 initialization example (#200)

* update readme with mobile support info and web3 initialization example

* add mobile section

* update to version 0.8.1

* change pageY and pageX to screenY and screenX (#204)

* add correct click handlers to close button touch start event (#206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal Close Button
2 participants