Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-size overwriting #2060

Closed
1 task done
Pasha8914 opened this issue Feb 1, 2024 · 3 comments · Fixed by #2072
Closed
1 task done

font-size overwriting #2060

Pasha8914 opened this issue Feb 1, 2024 · 3 comments · Fixed by #2072
Assignees
Labels
bug Something isn't working

Comments

@Pasha8914
Copy link

Pasha8914 commented Feb 1, 2024

Current Behavior

In web3-onboard there are variables for font size, but for variables are not used because fixed values are used for @media

Line 46 set variable for font-size, Line 86 overwrite to hardcode value

image

Expected Behavior

variables need to be used everywhere

Steps To Reproduce

  1. Open web3-onboard
  2. set display width more than 768px
  3. look at element-inspector

What package is effected by this issue?

@web3-onboard/core

Is this a build or a runtime issue?

N/A

Package Version

2.7.12

Node Version

20

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Relevant log output

No response

Anything else?

Because of this problem, I can't customize web3-onboard for my application. In my app 1rem = 10px; and the text in the modal window is too small, I tried to overwrite the data in the variables (custom styles guid) but found this bug

Sanity Check

  • If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.
@Pasha8914 Pasha8914 added the bug Something isn't working label Feb 1, 2024
@dan1kov
Copy link

dan1kov commented Feb 1, 2024

I have the same problem🤷‍♂️

@0xVoushi
Copy link

0xVoushi commented Feb 2, 2024

Same problem on my project

@Pasha8914
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants