Fix current url_options without a port (default port) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocknotes
previously requested changes
Feb 25, 2024
| @@ -20,7 +20,8 @@ def compose(source_keys, destination_key, **) | |||
| def current_host | |||
| opts = url_options || {} | |||
| url = "#{opts[:protocol]}#{opts[:host]}" | |||
| url + ":#{opts[:port]}" if opts[:port] | |||
| url += ":#{opts[:port]}" if opts[:port] | |||
There was a problem hiding this comment.
What about using << instead?
Suggested change
| url += ":#{opts[:port]}" if opts[:port] | |
| url << ":#{opts[:port]}" if opts[:port] |
There was a problem hiding this comment.
That is not a good idea while you still support ruby 2.7. Ruby 3 updated the frozen string literal setting to account for dynamic string literals, but ruby 2.7 will error can't modify frozen String for anyone that has turned that on globally because you have it enabled.
There was a problem hiding this comment.
Sorry for the late reply.
+= duplicates the string (you can make a test with object_id)
You can setup an unfrozen string when you are preparing it:
url = +"#{opts[:protocol]}#{opts[:host]}"
|
Also: please rebase your PR, the tests should work then. |
albus522
force-pushed
the
fix-missing-port
branch
from
1f5f910
to
8e4b680
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no port is specified on
ActiveStorage::Current.url_optionscurrent_hostwould returnnilinstead of"http://example.com"