Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve form control #10

Merged
merged 2 commits into from Jun 21, 2021
Merged

Improve form control #10

merged 2 commits into from Jun 21, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 20, 2021

I fixed the public_uri not passed in case of form error, so I pass the whole context.

Also, I add the proper HTML input type.

Copy link

@cnohall cnohall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, several small but important details are fixed.

  • Better error handling
  • Updated HTML Title (Satoshibox -> File Shop)
  • Price > 0
  • Email form now only accepts strings of the email type.

@cnohall cnohall merged commit 189273d into blockonomics:master Jun 21, 2021
@blockonomics
Copy link
Owner

@vv181 A total of 20USD has been accumulated for your 3 easy PR fixes till date. Feel free to state your bitcoin address to withdraw or you can continue progress and withdraw later

@ghost
Copy link
Author

ghost commented Jun 22, 2021

@vv181 A total of 20USD has been accumulated for your 3 easy PR fixes till date. Feel free to state your bitcoin address to withdraw or you can continue progress and withdraw later

Sure, here is my address: bc1qhnqgfmma6y00ksw9ktpzvvpqut0sa4d8n7y726
Thanks

@shivaenigma
Copy link

Paid 20 USD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants