New compiler fetcher #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenzing
force-pushed
the
lymarenkolev/new-fetcher
branch
from
1e3caef
to
34ae330
Compare
rimrakhimov
reviewed
Jun 22, 2022
rimrakhimov
reviewed
Jun 23, 2022
rimrakhimov
approved these changes
Jun 23, 2022
leviska
reviewed
Jun 23, 2022
leviska
reviewed
Jun 23, 2022
leviska
reviewed
Jun 23, 2022
leviska
reviewed
Jun 23, 2022
leviska
reviewed
Jun 23, 2022
rimrakhimov
reviewed
Jun 23, 2022
leviska
reviewed
Jun 23, 2022
leviska
reviewed
Jun 23, 2022
rimrakhimov
approved these changes
Jun 23, 2022
verification/src/main.rs
Outdated
Comment on lines
1
to
7
| use clap::Parser; | ||
| use verification::{run_http_server, Args, Config}; | ||
|
|
||
| #[tokio::main] | ||
| async fn main() -> std::io::Result<()> { | ||
| env_logger::init(); | ||
| let config = Config::parse().expect("Failed to parse config"); | ||
| let args = Args::parse(); |
There was a problem hiding this comment.
Nit: we may define Args::new constructor which calls Args::parse inside. That way we would not need to import clap::Parser anywhere outside of config.rs
There was a problem hiding this comment.
okay, but I will add default() instead of new()
sevenzing
force-pushed
the
lymarenkolev/new-fetcher
branch
from
5dc4612
to
f76ab35
Compare
sevenzing
force-pushed
the
lymarenkolev/new-fetcher
branch
2 times, most recently
from
4a01333
to
d57be13
Compare
leviska
reviewed
Jun 24, 2022
leviska
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.