Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not fail block internal_transactions_indexed_at field update #2738

Merged
merged 3 commits into from
Sep 30, 2019

Conversation

ayrat555
Copy link
Contributor

this runner updates internal_transactions_index_at field in blocks
table. but before this, it checks if these blocks are consensus, some
blocks may lose consensus.

we just shouldn't check if the number of updated records is exactly
equal to the number of records that we want to insert.
blocks that lost consensus will be re-fetched

Motivation

fixes

no match of right hand side value: {7, nil}
    (explorer) lib/explorer/chain/import/runner/internal_transactions_indexed_at_blocks.ex:71:

Changelog

  • do not fail block internal_transactions_indexed_at field update

this runner updates internal_transactions_index_at field in blocks
table. but before this, it checks if these blocks are consensus, some
blocks may lose consensus.

we just shouldn't check if the number of updated records is exactly
equal to the number of records that we want to insert.
blocks that lost consensus will be re-fetched
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9ad3e23e-4a86-4b87-9941-3ee7e793ee27

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 78.507%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/chain/import/runner/internal_transactions_indexed_at_blocks.ex 0 1 0.0%
Totals Coverage Status
Change from base Build 5218ecff-03d5-4bfc-952c-6f537d0a537a: 0.01%
Covered Lines: 5260
Relevant Lines: 6700

💛 - Coveralls

@vbaranov vbaranov merged commit e86b303 into master Sep 30, 2019
@vbaranov vbaranov deleted the ab-do-not-fail-blocks-runner branch September 30, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants