Fix BufferedTask initial stream #6991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
fix-buffered-task-initial-stream
branch
from
cd6945d
to
357239a
Compare
vbaranov
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6988
Related to #6951
Motivation
Currently, BufferedTask executes initial stream every time the flush is called. And, since it's working via
Task.Supervisor.async, it may cause large amount of fetcher'sinitexecution at the same time (especially if init stream executes complicated query) and therefore it may load database dramatically.Changelog
Added a guard for BufferedTask initial stream so it won't execute fetcher's
inituntil the previous one is done.