chore: bump elixir to 1.16.3 and Erlang OTP to 26.2.5 #9256
Conversation
| @@ -1,4 +1,4 @@ | |||
| defmodule Explorer.Token.InstanceMetadataRetrieverTest do | |||
| defmodule Indexer.Fetcher.TokenInstance.MetadataRetrieverTest do | |||
There was a problem hiding this comment.
Moved the test to get rid of Explorer -> Indexer dependency
| @@ -243,7 +243,8 @@ defmodule Indexer.BufferedTaskTest do | |||
| flush_timer: nil, | |||
| task_supervisor: BufferedTaskSup, | |||
| max_batch_size: 1, | |||
| max_concurrency: 1 | |||
| max_concurrency: 1, | |||
| poll: false | |||
There was a problem hiding this comment.
Seems like the test didn't properly work in elixir 1.14, didn't manage to debug the reason why.
Without poll: false, BufferedTask will attempt to call init/2 when given an empty queue.
| @@ -143,7 +143,7 @@ defmodule Explorer.ExchangeRates.Source.CoinGeckoTest do | |||
| Application.put_env(:explorer, CoinGecko, base_url: "http://localhost:#{bypass.port}") | |||
|
|
|||
| on_exit(fn -> | |||
| Application.put_env(:explorer, :coin, "POA") | |||
| Application.put_env(:explorer, :coin, "ETH") | |||
There was a problem hiding this comment.
Setting env to a non-default value breaks test sometimes in a different file.
| @@ -118,15 +117,15 @@ defmodule Explorer.Account.Notifier.Email do | |||
| end | |||
|
|
|||
| defp address_url(address_hash) do | |||
| Helpers.address_url(uri(), :show, address_hash) | |||
| uri() |> URI.append_path("/address/#{address_hash}") |> to_string() | |||
There was a problem hiding this comment.
Elixir doesn't like cyclic dependencies now, so this is probably the easiest way to remove Explorer -> BlockScoutWeb dependency
| # OS process metrics for Prometheus | ||
| {:prometheus_process_collector, "~> 1.3"}, | ||
| # OS process metrics for Prometheus, custom ref to include https://github.com/deadtrickster/prometheus_process_collector/pull/30 | ||
| {:prometheus_process_collector, |
There was a problem hiding this comment.
There is a new upstream release for prometheus_ex, btw - https://github.com/deadtrickster/prometheus.ex/releases/tag/v3.1.0
We might wanna update in a separate PR.
k1rill-fedoseev
requested review from
nikitosing,
sl1depengwyn and
Qwerty5Uiop
| @@ -18,6 +18,8 @@ defmodule Explorer.MarketTest do | |||
| end | |||
|
|
|||
| test "fetch_recent_history/1" do | |||
| ConCache.delete(:market_history, :last_update) | |||
There was a problem hiding this comment.
Another test cached an empty value causing this test to fail.
There was a problem hiding this comment.
@k1rill-fedoseev could you please rebase to master branch? There are merging conflicts currently: I recently moved OTP_VERSION and ELIXIR_VERSION to github envs and re-used them in Github actions workflows.
k1rill-fedoseev
force-pushed
the
kf-bump-elixir-1.16.0
branch
from
e44d381
to
2cfba96
Compare
k1rill-fedoseev
changed the title
k1rill-fedoseev
force-pushed
the
kf-bump-elixir-1.16.0
branch
from
263e0d0
to
e22f9e7
Compare
k1rill-fedoseev
force-pushed
the
kf-bump-elixir-1.16.0
branch
from
e22f9e7
to
4086eb5
Compare
k1rill-fedoseev
changed the title
k1rill-fedoseev
changed the title
k1rill-fedoseev
force-pushed
the
kf-bump-elixir-1.16.0
branch
from
833eab6
to
36d7010
Compare
Changelog
prometheus_process_collectordependencyChecklist for your Pull Request (PR)
CHANGELOG.mdwith this PRmasterin the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.