Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Missing JSON-RPC errors handling #58

Closed
rockfridrich opened this issue Feb 23, 2018 · 11 comments
Closed

Missing JSON-RPC errors handling #58

rockfridrich opened this issue Feb 23, 2018 · 11 comments
Labels

Comments

@rockfridrich
Copy link
Member

If JSON-RPC returns an error in JSON than network layer should throw an error with description

@0crat
Copy link

0crat commented Feb 23, 2018

@Biboran/z please, pay attention to this issue

@0crat
Copy link

0crat commented Feb 23, 2018

Job #58 is now in scope, role is DEV

@0crat
Copy link

0crat commented Feb 23, 2018

Thanks for your contribution, @rockfridrich/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

@0crat
Copy link

0crat commented Apr 3, 2018

The job #58 assigned to @Biboran/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and thisWe should be aware that biboran is on vacation; this ticket may be delayed

@0crat
Copy link

0crat commented Apr 8, 2018

@Biboran/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@abdulowork
Copy link
Contributor

I don't like the approach of checking the response every time to see if it has response or error field.

SwiftyJSON doesn't retain the bottom of the JSON tree, therefore it will not be possible to check for error nonredunduntly. We need to implement support for climbing JSON tree first.

@abdulowork
Copy link
Contributor

@0crat waiting

@0crat
Copy link

0crat commented Apr 12, 2018

@0crat waiting (here)

@Biboran The impediment for #58 was registered successfully by @Biboran/z

@0crat
Copy link

0crat commented Jun 8, 2018

Order was finished: +30 point(s) just awarded to @Biboran/z

@0crat
Copy link

0crat commented Jun 8, 2018

The job #58 is now out of scope

@0crat
Copy link

0crat commented Jun 8, 2018

I'm not managing zeriontech/web3swift GitHub repository, you have to contact me in Slack first, see §11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants