Search, Canonical Pages URL, Metadata fixes #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Fixes Search -Cleans up controller code Notes for future: getBlogPosts() Method should be moved to domain if possible. DTO object needed?
|
There's still an open bug in this pull request:
|
fullreboot
force-pushed
the
SearchFix
branch
from
fd8a71c
to
4be17ae
Compare
Added controller with explicit route /admin to catch request to admin page and serve proper index.html. Previously this route was being incorrectly handled by the /{slug} controller action
|
MVC Catch-All error has been fixed. While implementing the new pages canonical urls from Fixed in this commit which was automatically added to the PR
|
rxtur
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixes Search
-Cleans up controller code
-Fixes Pages canonical url (/posts/page-title --> /page-title)
Notes for future: getBlogPosts() and getSingleBlogPost() Method should be moved to domain if possible.