Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message after account confirmation #1122

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Conversation

software-project
Copy link
Contributor

@software-project software-project commented Apr 13, 2021

Resolves #1119 and #1118

@exygy-dev exygy-dev temporarily deployed to bloom-refere-fix-token--z57vmg April 13, 2021 15:48 Inactive
@netlify
Copy link

netlify bot commented Apr 13, 2021

Deploy preview for clever-edison-cd22c1 ready!

Built with commit c0f7ca9

https://deploy-preview-1122--clever-edison-cd22c1.netlify.app

@exygy-dev exygy-dev temporarily deployed to bloom-refere-fix-token--m9yezr April 14, 2021 09:22 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-fix-token--wptsec April 14, 2021 09:42 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-fix-token--z8xhs7 April 14, 2021 15:22 Inactive
@slowbot
Copy link
Collaborator

slowbot commented Apr 14, 2021

@software-project Ideally the user wouldn't see the homepage at all. They would be directly to the dashboard immediately. Is that possible? If not we can merge this since its better than what we have and refine. @kathyccheng

@software-project
Copy link
Contributor Author

@software-project Ideally the user wouldn't see the homepage at all. They would be directly to the dashboard immediately. Is that possible? If not we can merge this since its better than what we have and refine. @kathyccheng

@slowbot unfortunately it's not possible as we are pinging frontend server that needs to first render a page, run a validation call to backend and then it can redirect to dashboard. I suppose initial call could be to a page with a loading spinner, with would make the experience maybe a bit better. Maybe with Nextjs update it will be possible, but I'm not sure. @jaredcwhite ?

Copy link
Collaborator

@dominikx96 dominikx96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was redirected to the dashboard and I saw a success message, it looks good!

Also, email formatting is as expected.

Copy link
Collaborator

@dominikx96 dominikx96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format Confirm Account Email
4 participants