fix: coliseum preferences issues - allow optional description & generic decline #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyjablonski
added
the
wip
|
✔️ Deploy Preview for clever-edison-cd22c1 ready! 🔨 Explore the source changes: 51b7c29 🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/60ae5d98e36acc0008d1f82c 😎 Browse the preview: https://deploy-preview-1267--clever-edison-cd22c1.netlify.app |
emilyjablonski
added
ready for review
and removed
wip
emilyjablonski
changed the title
emilyjablonski
added
wip
jaredcwhite
approved these changes
May 25, 2021
| </p> | ||
| </ExpandableContent> | ||
| </div> | ||
| {!(option.description === false) && ( |
There was a problem hiding this comment.
Maybe use option.description !== false?
emilyjablonski
commented
May 25, 2021
| @@ -184,132 +184,138 @@ const ApplicationPreferencesAll = () => { | |||
|
|
|||
| <Form onSubmit={handleSubmit(onSubmit)}> | |||
| <> | |||
| <div className="form-card__group px-0 pb-0"> | |||
There was a problem hiding this comment.
Big diff! The only thing I did was move this into the map - nothing else :) git's "hide whitespace" setting helps this a bunch
emilyjablonski
added
ready for review
and removed
wip
emilyjablonski
force-pushed
the
preferences-issues
branch
from
ac2927e
to
51b7c29
Compare
willrlin
referenced
this pull request
in CityOfDetroit/bloom
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue
Addresses #1199
Description
The new preference request out of Coliseum requires that we be able to have preferences that don't have a description, that we don't automatically always show the "I don't want these preferences" option, and that we can have custom select text.
Below are two screenshots of the Coliseum OHA preference before this change and after this change. You can see in the before, the issues are that "read more" shows for the
None of these preferences apply to me...andI don't want to be considered...options but there actually isn't a description to show for those, that theI don't want these preferencesstill shows even though we don't want it to, and that it reads "If you have one of these housing preferences...".I added three new optional fields on preference to set the description to false for an individual preference, to hide the generic decline text from a preference set, and to add custom select text.
Type of change
How Can This Be Tested/Reviewed?
You will need to import the Coliseum listing. You can find it here.
Checklist: