-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optionally hide preferences from listing page #1280
Conversation
✔️ Deploy Preview for clever-edison-cd22c1 ready! 🔨 Explore the source changes: 31d02be 🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/60b114bbd7eee00007ad2b09 😎 Browse the preview: https://deploy-preview-1280--clever-edison-cd22c1.netlify.app |
const filteredPreferences = props.preferences.filter( | ||
(pref) => !pref.formMetadata?.hideFromListing | ||
) | ||
const preferences = filteredPreferences.map((preference: Preference, index: number) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to not chaining, since it can be harder to read, so just a suggestion:
const preferences = props.preferences
.filter((preference: Preference) => !preference.formMetadata?.hideFromListing)
.map((preference: Preference, index: number) => {}
This reverts commit 519703f.
This reverts commit 519703f.
Pull Request Template
Issue
No issue, came out of Coliseum QA
Description
Coliseum has requested that the OHA and HOPWA preferences not show on the Listing page, even though they'll show in the preferences section of the application. So, yet another optional flag :/ Meep moop. Hoping we can wrap up all these changes into a new section more relevant to how these "preferences" actually work soon.
Type of change
How Can This Be Tested/Reviewed?
Import Coliseum, look at the listing page's preferences section, you should only see Live/Work.
Checklist: