Upgrade to tailwind v2 #1805
Upgrade to tailwind v2 #1805
Conversation
* Also remove unneeded React imports
|
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 949c498 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/61412f6ea25c610007c62cb8 😎 Browse the preview: https://deploy-preview-1805--dev-storybook-bloom.netlify.app |
|
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: 949c498 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/61412f6e5dce7d000967cf52 😎 Browse the preview: https://deploy-preview-1805--dev-partners-bloom.netlify.app |
|
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: 949c498 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/61412f6eaf5b4000071468e7 😎 Browse the preview: https://deploy-preview-1805--dev-bloom.netlify.app |
| @@ -117,13 +117,6 @@ | |||
| dependencies: | |||
| "@babel/highlight" "^7.10.4" | |||
|
|
|||
| "@babel/code-frame@7.8.3": | |||
There was a problem hiding this comment.
This is a satisfying added/removed diff 😅
(there's no newer Docker image available at present)
|
Finally got it in a mergeable state with all checks passing! 🙌 |
|
Do you have any suggestions for how to test or review this? It LGTM :) |
|
@seanmalbert , a note to myself to test if we can easily now use the rtl plugin for tailwind. |
|
@emilyjablonski I'm not sure how much we can verify through tests other than the general infrastructure isn't horribly broken…for me, double-checking the Next/React/Tailwind combo, I just clicked through a bunch of the stuff in Storybook and then various pages on the public/partners sites and did some side-by-side comparisons with the dev branch. Thus far I've resolved the few anomalies I found. Hopefully after a couple other folks giving it a once over, we'll feel reasonablly confident any potential variance is minor and sporadic. |
There was a problem hiding this comment.
Looks good, @jaredcwhite! I also tested this to make sure tailwind plugins worked with this setup and they do, so I'm going to put out a separate PR for that.
|
I think we can merge this and send to QA at this point so we can have more eyes on any potential variances. |
|
@emilyjablonski Actually I forgot this doesn't include the purge step. Prob don't need to do much A/B comparison until we get to #1823 |
* Upgrade to Next 11 and React 17 * Switch pages from MDX to markdown-to-jsx * Also remove unneeded React imports * Use tsx for Next error pages * Fix lack of semantic heading on Listing photo form * Add bloom-housing#1793 to Changelog * Upgrade to Tailwind 2, PostCSS 8, Storybook 6.3 * Upgade Changelook with bloom-housing#1805 * Upgrade to Node 14 * Update `.node-version` file * Testing explicit tailwind dep on Netlify * Update partners also with tailwind dep * Update Node version in CircleCI * Use Node 14.17.4 instead for security fixes * Whoops, make that 14.17.6 =) * Bump Cypress in CircleCI back down to 14.17.0 (there's no newer Docker image available at present) * Bump up React Hook Form in public app * Fix lockfile, update GitHub lint action * Remove stray </td> causing a linting issue * Fix code style issues with Prettier * new lines on two files * export updates Co-authored-by: Lint Action <lint-action@samuelmeuli.com> Co-authored-by: seanmalbert <smabert@gmail.com>
Issue
Addresses #1685, #857, and #1684 (also dup #288).
Description
The monorepo is upgraded to require Node 14. Both partners and public sites are upgraded to Next 11 (and Webpack 5), plus React is bumped to v17 across the sites and ui-components packages. TailwindCSS is upgraded to v2 along with PostCSS 8. Storybook in ui-components is upgraded to 6.3.
Type of change
Checklist: