Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1725/remove dependencies from hero component #1816

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Sep 10, 2021

Pull Request Template

Issue

Addresses #1725

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Removes backend dependencies from Hero component

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

The change toggles the existence of text on the home page that indicates all listings are closed. You can check out Storybook.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

@emilyjablonski emilyjablonski changed the base branch from master to dev September 10, 2021 20:50
@emilyjablonski emilyjablonski linked an issue Sep 10, 2021 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Sep 10, 2021

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: 3068304

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/613bc4c30da6800008c4ff67

😎 Browse the preview: https://deploy-preview-1816--clever-edison-cd22c1.netlify.app

@netlify
Copy link

netlify bot commented Sep 10, 2021

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: 4302c29

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/613bc5027c84770008a04e80

😎 Browse the preview: https://deploy-preview-1816--clever-edison-cd22c1.netlify.app

Copy link
Contributor

@akegan akegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jaredcwhite jaredcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilyjablonski emilyjablonski merged commit e0bddb1 into dev Sep 13, 2021
@emilyjablonski emilyjablonski deleted the 1725/remove-deps-hero branch September 13, 2021 19:08
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove business logic from Hero
3 participants